floscr/clj-ui-framework
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: use #shadow/env for replicant dev-http port instead of rewriting config

Browse Source 
Replace the pattern of reading shadow-cljs.edn, mutating it with
pr-str (which destroyed formatting), and writing it back. Instead,
use shadow-cljs's built-in `#shadow/env` reader tag to read the port
from the SHADOW_HTTP_PORT environment variable at startup, with a
default of 3001.

Both `dev-replicant` and `dev-all` tasks now pass the port via env var
instead of file mutation. This eliminates the dirty-file problem where
the rewritten single-line config would show up as an unrelated change.
This commit is contained in:
Florian Schroedl
2026-03-05 14:43:29 +01:00
parent e003e1c4a8
commit 4f42dce649
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
bb.edn
View File

@@ -77,13 +77,10 @@
dev-replicant
{:doc "Start replicant dev server (PORT env var, default 3001)"
:depends [build-theme ensure-npm]
:requires ([clojure.edn :as edn])
:task (let [port (some-> (System/getenv "PORT") parse-long)
cfg-path "dev/replicant/shadow-cljs.edn"]
(when port
(let [cfg (edn/read-string (slurp cfg-path))]
(spit cfg-path (pr-str (assoc cfg :dev-http {port "public"})))))
(shell {:dir "dev/replicant"} "npx" "shadow-cljs" "watch" "app"))}
env (cond-> {} port (assoc "SHADOW_HTTP_PORT" (str port)))]
(shell {:dir "dev/replicant" :extra-env env}
"npx" "shadow-cljs" "watch" "app"))}
dev-squint
{:doc "Start squint dev server (PORT env var, default 3002)"
@@ -108,21 +105,16 @@
dev-all
{:doc "Start all dev servers in tmux panes (bb dev-all [BASE_PORT], default 3000)"
:depends [build-theme ensure-npm]
:requires ([clojure.edn :as edn])
:task (let [base (or (some-> (first *command-line-args*) parse-long) 3000)
rport (+ base 1)
sport (+ base 2)
hport (+ base 3)
session "ui-dev"
;; Write shadow-cljs.edn with the correct port before launching
cfg-path "dev/replicant/shadow-cljs.edn"
cfg (edn/read-string (slurp cfg-path))]
(spit cfg-path (pr-str (assoc cfg :dev-http {rport "public"})))
session "ui-dev"]
(shell {:continue true} "tmux kill-session -t" session)
(shell "tmux new-session -d -s" session
(str "PORT=" hport " bb dev-hiccup"))
(shell "tmux split-window -h -t" session
(str "bash -c 'cd dev/replicant && npx shadow-cljs watch app'"))
(str "bash -c 'cd dev/replicant && SHADOW_HTTP_PORT=" rport " npx shadow-cljs watch app'"))
(shell "tmux split-window -v -t" session
(str "bash -c 'cd dev/squint && npx squint watch"
" & cd dev/squint && npx vite --port " sport "'"))